Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

feat: expose contract addresses in deploy script stdout #88

Merged
merged 7 commits into from
Jun 16, 2023
Merged

feat: expose contract addresses in deploy script stdout #88

merged 7 commits into from
Jun 16, 2023

Conversation

sebastiendan
Copy link
Member

@sebastiendan sebastiendan commented Jun 15, 2023 •
edited
Loading

Description

This PR update the deploy scripts to only console.log key information, so that callers can retrieve the said information from the command's stdout. This is key to abstracting contract addresses in local-erc20-messaging-infra and e2e-tests.

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

@sebastiendan sebastiendan self-assigned this Jun 15, 2023
@sebastiendan sebastiendan changed the title feat: add predict contract address script feat: expose contract addresses in deploy script stdout Jun 16, 2023
@sebastiendan sebastiendan marked this pull request as ready for review June 16, 2023 18:02
@sebastiendan sebastiendan merged commit 03cee85 into main Jun 16, 2023
@sebastiendan sebastiendan deleted the feat/add-predict-addr-script branch June 16, 2023 20:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JDawg287 JDawg287 JDawg287 approved these changes

Assignees

@sebastiendan sebastiendan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebastiendan @JDawg287